harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Pervov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-3198) [drlvm] several uncertain changes need careful review
Date Fri, 23 Feb 2007 12:03:06 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475319

Pavel Pervov commented on HARMONY-3198:

Attached patch fixes issues discovered.

> [drlvm] several uncertain changes need careful review
> -----------------------------------------------------
>                 Key: HARMONY-3198
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3198
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: DRLVM
>         Environment: windows/em64t
>            Reporter: Ivan Zvolsky
>         Attachments: H3198.patch
> drlvm_need_impl.patch also contains 3 somewhat questionable changes:
> 1) line 11: drlvm didn't compile with 'private' modifier under windows/em64t but compiler
fine without. I workarounded this by removing it for windows/em64t, but the modifier certainly
needs to be there.
> 2) line 28: same as above - the line must be uncommented, but I couldn't find the way
to fix compilation problem quickly, so I removed the line for windows/em64t.
> 3) line 113: couldn't compile that "as is", so had to replace the line with something
different, but i'm not sure they are equivalent.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message