Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <9945173.1168608387550.JavaMail.jira@brutus>
Date: Fri, 12 Jan 2007 05:26:27 -0800 (PST)
From: "Alexei Zakharov (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-1171) [classlib][jndi] no
 InvalidNameException for CompoundName.addAll()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HARMONY-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464199 ] 

Alexei Zakharov commented on HARMONY-1171:
------------------------------------------

Hi Vasiliy, thanks for patches. I'm still confused a bit with the situation when Sun throws NullPointerException if the null value is specified and we throw IllegalArgumentException in the same case. IIRC we have discussed the situation when RI throws *nothing*. In this case we may probably throw anything we want. But if RI throws NPE and it is the case then IMHO we should follow this behavior.

> [classlib][jndi] no InvalidNameException for CompoundName.addAll()
> ------------------------------------------------------------------
>
>                 Key: HARMONY-1171
>                 URL: https://issues.apache.org/jira/browse/HARMONY-1171
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Vladimir Ivanov
>         Assigned To: Alexei Zakharov
>         Attachments: CompoundNameTest.patch, Harmony-1171-New.patch, Harmony-1171-Test-New.patch, Harmony-1171-Test.patch, Harmony-1171.patch, Harmony-1171.patch
>
>
> The method CompoundName().addAll() works silently on Harmony and throws InvalidNameException on RI.
> ==================== test.java ============================
> import javax.naming.*;
> import java.util.Properties;
> public class test {
>     public static void main(String args[]) throws Exception {
>         new CompoundName("aaa", new Properties()).addAll(new CompoundName("bbb", new Properties()));
>     }
> }
> =======================================================
> Output:
> C:\tmp\tmp17>C:\jrockit-jdk1.5.0-windows-ia32\bin\java.exe -cp . -showversion test
> java version "1.5.0"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0-b64)
> BEA WebLogic JRockit(R) (build dra-38972-20041208-2001-win-ia32, R25.0.0-75, GC: System optimized over throughput (initial strategy singleparpar))
> javax.naming.InvalidNameException: A flat name can only have a single component
>         at javax.naming.NameImpl.addAll(NameImpl.java:621)
>         at javax.naming.CompoundName.addAll(CompoundName.java:442)
>         at test.main(test.java:6)
> C:\tmp\tmp17>C:\harmony\classlib1.5\deploy\jdk\jre\bin\java.exe -cp . -showversion test
> java version 1.5 (subset)
> (c) Copyright 1991, 2006 The Apache Software Foundation or its licensors, as applicable.
> C:\tmp\tmp17>C:\harmony\drlvm1.5\build\win_ia32_msvc_debug\deploy\jre\bin\java -Dvm.assert_dialog=false -cp . -showversion test
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r431304, (Aug 14 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira