Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 61554 invoked from network); 25 Jan 2007 13:44:10 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 25 Jan 2007 13:44:10 -0000 Received: (qmail 32800 invoked by uid 500); 25 Jan 2007 13:44:16 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 32778 invoked by uid 500); 25 Jan 2007 13:44:16 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 32766 invoked by uid 99); 25 Jan 2007 13:44:16 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Jan 2007 05:44:16 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Jan 2007 05:44:09 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 610287142D7 for ; Thu, 25 Jan 2007 05:43:49 -0800 (PST) Message-ID: <5727726.1169732629394.JavaMail.jira@brutus> Date: Thu, 25 Jan 2007 05:43:49 -0800 (PST) From: "Mikhail Loenko (JIRA)" To: commits@harmony.apache.org Subject: [jira] Closed: (HARMONY-840) [classlib][beans] enabling of tests from StatementTest class (3) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Loenko closed HARMONY-840. ---------------------------------- done > [classlib][beans] enabling of tests from StatementTest class (3) > ---------------------------------------------------------------- > > Key: HARMONY-840 > URL: https://issues.apache.org/jira/browse/HARMONY-840 > Project: Harmony > Issue Type: Improvement > Environment: winXP > Reporter: Alexei Zakharov > Assigned To: Mikhail Loenko > Attachments: StatementTest3.patch > > > Attached patch enables two more tests from org.apache.harmony.beans.tests.java.beans.StatementTest: > testExecute_ArrayGet > testExecute_ArrayInvalidSet > What have been done: > 1. I have reworked the exception throwing model of Statement.findArrayMethod(). Now our implementation throws the same set of exceptions as RI does. > 2. I have also removed superfluous parameters from "get" and "set" invocations from tests since tests in their old form were invalid. However, old variants of tests pass on RI. IMHO it is RI bug. I have started new mail thread in the list about this topic. Anyway, even if we decide to be 100% compatible with RI here we will probably need do define an extra test. We don't need to test this doubtful logic in these tests IMHO. > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.