Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <31603991.1168808187519.JavaMail.jira@brutus>
Date: Sun, 14 Jan 2007 12:56:27 -0800 (PST)
From: "Mark Hindess (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-2753) [classlib][swing]
 javax.swing.LayoutFocusTraversalPolicy.getFirstComponent(null) throws NPE
 instead of IAE
In-Reply-To: <3289346.1166195001188.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HARMONY-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464619 ] 

Mark Hindess commented on HARMONY-2753:
---------------------------------------

For me, the tests pass even without the fix?  Is it still required?


> [classlib][swing] javax.swing.LayoutFocusTraversalPolicy.getFirstComponent(null) throws NPE instead of IAE
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2753
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2753
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexander Simbirtsev
>         Attachments: H2753-LayoutFocusTraversalPolicyTest.patch, H2753-LayoutFocusTraversalPolicyTest.patch, LayoutFocusTraversalPolicy-patch.txt
>
>
> According to the specification
> javax.swing.LayoutFocusTraversalPolicy.getFirstComponent/getLastComponent(Container
> aContainer) must throw IllegalAgumentexception is aContainer==null.
> RI throws IAE while Harmony throws NPE.
> Use the following code to reproduce:
> import javax.swing.LayoutFocusTraversalPolicy;
> import junit.framework.TestCase;
> public class Test extends TestCase {       
>     public void testcase1() {
>         LayoutFocusTraversalPolicy pl = new LayoutFocusTraversalPolicy();       
>         try {
>             pl.getFirstComponent(null);
>             fail("IllegalAgumentexception should be thrown");
>         } catch (IllegalArgumentException e) {
>             //expected
>         } catch (NullPointerException e) {
>             fail("IllegalAgumentexception should be thrown");
>         }
>     } 
>     public void testcase2() {
>         LayoutFocusTraversalPolicy pl = new LayoutFocusTraversalPolicy();       
>         try {
>             pl.getLastComponent(null);
>         } catch (IllegalArgumentException e) {
>             //expected
>         } catch (NullPointerException e) {
>             fail("IllegalAgumentexception should be thrown");
>         }      
>     }      
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira