Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <30172427.1168935867520.JavaMail.jira@brutus>
Date: Tue, 16 Jan 2007 00:24:27 -0800 (PST)
From: "Leo Li (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Updated: (HARMONY-3008) [classlib][instrument]Releases byte
 array too early in the native code of redefine classes.
In-Reply-To: <30169940.1168931487496.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HARMONY-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leo Li updated HARMONY-3008:
----------------------------

    Attachment: patch-3008.diff

> [classlib][instrument]Releases byte array too early in the native code of redefine classes.
> -------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3008
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3008
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Leo Li
>         Attachments: patch-3008.diff
>
>
> In instrument.c, Java_org_apache_harmony_instrument_internal_InstrumentationImpl_redefineClasses_1native, we have:
> Line 237:
>      class_bytes = (*env)->GetByteArrayElements(env, jclass_bytes, &copy);
> 		  if(NULL == class_bytes){
> 			hymem_free_memory(class_definitions);
> 			return;
> 		  }
> 		  class_byte_count = (*env)->GetArrayLength(env, jclass_bytes);
>           if(copy == JNI_TRUE){
> 		    (*env)->ReleaseByteArrayElements(env,jclass_bytes, class_bytes, JNI_ABORT);
>           }
> 	  
> 		  //construct a jvmtiClassDefinition element		  
> 		  class_definitions[index].klass=klass;
> 		  class_definitions[index].class_bytes=class_bytes;
> 		  class_definitions[index].class_byte_count=class_byte_count;
> 	  }
> 	  //perform redefinition
> 	  err=(*jvmti)->RedefineClasses(jvmti, length, class_definitions);
> the class_bytes are freed before RedefineClasses of JVM_TI uses them.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira