Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 39861 invoked from network); 16 Jan 2007 11:47:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 16 Jan 2007 11:47:49 -0000 Received: (qmail 64368 invoked by uid 500); 16 Jan 2007 11:47:55 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 64316 invoked by uid 500); 16 Jan 2007 11:47:55 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 64307 invoked by uid 99); 16 Jan 2007 11:47:55 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jan 2007 03:47:55 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jan 2007 03:47:48 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 1F8157142BD for ; Tue, 16 Jan 2007 03:47:28 -0800 (PST) Message-ID: <30171170.1168948048126.JavaMail.jira@brutus> Date: Tue, 16 Jan 2007 03:47:28 -0800 (PST) From: "Mark Hindess (JIRA)" To: commits@harmony.apache.org Subject: [jira] Commented: (HARMONY-2653) [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException In-Reply-To: <32672233.1165935921121.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465136 ] Mark Hindess commented on HARMONY-2653: --------------------------------------- So to be clear, you are saying that the fail I placed before the first catch isn't required because an implementation would be correct even if it didn't throw the expected NullPointerException? To me it appears that if the RI throws a NPE then we *must* and not throwing it should be a failure. > [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException > -------------------------------------------------------------------------------------------------------------------------------- > > Key: HARMONY-2653 > URL: https://issues.apache.org/jira/browse/HARMONY-2653 > Project: Harmony > Issue Type: Bug > Components: Classlib > Reporter: Alexander Simbirtsev > Attachments: BasicListUI-patch.txt, H2653-BasicListUITest.patch > > > There is no mention of any exception in the specification. > Harmony throws unspecified ClassCastException for getPreferredSize(new JFileChooser()) while RI throws unspecified NPE. > Use the following code to reproduce: > import javax.swing.JFileChooser; > import javax.swing.plaf.basic.BasicListUI; > import junit.framework.TestCase; > public class Test extends TestCase { > public void testcase1() { > try { > BasicListUI bl = new BasicListUI(); > bl.getPreferredSize(new JFileChooser() ); > } catch (NullPointerException e) { > //expected > } catch (ClassCastException e) { > fail("No NPE thrown"); > } > } > } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira