Return-Path: 
 <commits-return-24777-apmail-harmony-commits-archive=harmony.apache.org@harmony.apache.org>
Delivered-To: apmail-harmony-commits-archive@www.apache.org
Received: (qmail 903 invoked from network); 10 Jan 2007 13:27:50 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 10 Jan 2007 13:27:50 -0000
Received: (qmail 43389 invoked by uid 500); 10 Jan 2007 13:27:51 -0000
Delivered-To: apmail-harmony-commits-archive@harmony.apache.org
Received: (qmail 43246 invoked by uid 500); 10 Jan 2007 13:27:51 -0000
Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@harmony.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@harmony.apache.org>
List-Post: <mailto:commits@harmony.apache.org>
List-Id: <commits.harmony.apache.org>
Reply-To: dev@harmony.apache.org
Delivered-To: mailing list commits@harmony.apache.org
Received: (qmail 43175 invoked by uid 99); 10 Jan 2007 13:27:50 -0000
Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2007 05:27:50 -0800
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2007 05:27:42 -0800
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id A6E5541002E
	for <commits@harmony.apache.org>; Wed, 10 Jan 2007 04:58:28 -0800 (PST)
Message-ID: <22069146.1168433908662.JavaMail.jira@brutus>
Date: Wed, 10 Jan 2007 04:58:28 -0800 (PST)
From: "Alexey Varlamov (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-2859) [drlvm][build] tests continue run
 after test failure
In-Reply-To: <25219096.1166798066573.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/HARMONY-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463545 ] 

Alexey Varlamov commented on HARMONY-2859:
------------------------------------------

Vladimir, this is right move. I'm see the following areas for improvement:
1) Use equivalent <fail if="test.failed" unless="run.all.tests.flag"> instead of 
+        <fail>
+            <condition>
+                <and>
+                    <isset property="test.failed" />
+                    <not>
+                        <isset property="run.all.tests.flag" />
+                    </not>
+                </and>
+            </condition>
+        </fail>
2) Do not introduce status property for each suite, use just one property - intersection is harmless here.
3) Omit ".flag" suffix.

> [drlvm][build] tests continue run after test failure
> ----------------------------------------------------
>
>                 Key: HARMONY-2859
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2859
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Vladimir Ivanov
>         Assigned To: Alexey Varlamov
>            Priority: Minor
>         Attachments: test.patch, test.patch
>
>
> The vm build stopped after the test failure. It is prevent the build from the full automatic testing.
> I suggest to always run all test and look always on results.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira