Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <20495726.1170244025994.JavaMail.jira@brutus>
Date: Wed, 31 Jan 2007 03:47:05 -0800 (PST)
From: "Alexey Varlamov (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Resolved: (HARMONY-2470) [classlib][luni][test] Harmony unit
 test
 org.apache.harmony.luni.tests.java.lang.PackageTest.test#isCompatibleWithLjava_lang_String
 is incorect
In-Reply-To: <4946735.1165328784518.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HARMONY-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Varlamov resolved HARMONY-2470.
--------------------------------------

    Resolution: Fixed

Mikhail, thanks for the patches. 
I agree with the fix but instead of dropping testcase, it should be reversed. As IBM VME behaves differently, I suggest to file separate issue and excude the test.
I cleaned/fixed the whole PackageTest (sorry for possibly messing diffs) and fixed the DRLVM at r501814.

> [classlib][luni][test] Harmony unit test org.apache.harmony.luni.tests.java.lang.PackageTest.test#isCompatibleWithLjava_lang_String is incorect
> -----------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2470
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2470
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Artem Aliev
>         Assigned To: Alexey Varlamov
>         Attachments: H-2470_drlvm.patch, H-2470_test.patch
>
>
> According to J2SE API 5.0 specifications of java.lang.Package class:
> "Specification version numbers use a syntax that consists of positive decimal 
> integers separated by periods ".", for example "2.0" or "1.2.3.4.5.6.7". This 
> allows an extensible number to be used to represent major, minor, micro, etc. 
> versions. The version specification is described by the following formal 
> grammar: 
> SpecificationVersion: 
>     Digits RefinedVersionopt 
> RefinedVersion: 
>     . Digits 
>     . Digits RefinedVersion 
> Digits: 
>     Digit 
>     Digits 
> Digit: 
>     any character for which Character.isDigit(char) returns true, e.g. 0, 1, 
>     2, ... 
> "
> But the following Harmony unit test 
> org.apache.harmony.luni.tests.java.lang.PackageTest.test invokes
> Package.isCompatibleWith(String) with incorrect argument "2.1.9." to compare
> package's specification version with a desired version.
> See test case "test_isCompatibleWithLjava_lang_String".
> As the result this test case fails on RI and reports:
> test_isCompatibleWithLjava_lang_String(org.apache.harmony.luni.tests.java.lang.PackageTest)junit.framework.AssertionFailedError:
> Exception during isCompatibleWith test : For input string: ""
>         at
> org.apache.harmony.luni.tests.java.lang.PackageTest.test_isCompatibleWithLjava_lang_String(PackageTest.java:331)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>         at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.