Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <17227830.1168881447880.JavaMail.jira@brutus>
Date: Mon, 15 Jan 2007 09:17:27 -0800 (PST)
From: "Mark Hindess (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-2903) [classlib][swing]
 j.s.plaf.basic.BasicOptionPaneUI.getIconForType() doesn't throw NPE
In-Reply-To: <27530680.1167234081047.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HARMONY-2903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464869 ] 

Mark Hindess commented on HARMONY-2903:
---------------------------------------

I tried applying the test patch but it fails before getting to the new part.  I fails on the line:

        assertEquals(icon11, icon12);


> [classlib][swing] j.s.plaf.basic.BasicOptionPaneUI.getIconForType() doesn't throw NPE
> -------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2903
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2903
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib, Non-bug differences from RI
>            Reporter: Alexey A. Ivanov
>            Priority: Minor
>         Attachments: Harmony-2903-Make.patch, Harmony-2903-Test.patch, Harmony-2903.patch
>
>
> javax.swing.plaf.basic.BasicOptionPaneUI.getIconForType(int) returns non-null icon whereas RI throws NPE:
> java.lang.NullPointerException
> 	at sun.swing.DefaultLookup.get(DefaultLookup.java:81)
> 	at javax.swing.plaf.basic.BasicOptionPaneUI.getIconForType(BasicOptionPaneUI.java:551)
> 	at Test$TestBasicOptionPaneUI.getIconForType(Test.java:8)
> 	at Test.main(Test.java:14)
> Note: if UI is associated with a JOptionPane, then RI returns an icon too and no exception is thrown.
> (Add the following line before System.out:
>         bop.installUI(new JOptionPane());
> )
> ======= Code to Reproduce =======
> import javax.swing.Icon;
> import javax.swing.plaf.basic.BasicOptionPaneUI;
> public class Test {
>     private static class TestBasicOptionPaneUI extends BasicOptionPaneUI {
>         @Override
>         public Icon getIconForType(int i) {
>             return super.getIconForType(i);
>         }
>     }
>     public static void main(String[] args) {
>         TestBasicOptionPaneUI bop = new TestBasicOptionPaneUI();
>         System.out.println(bop.getIconForType(0));
>     }
> }
> ======= end of code =======

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira