Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <15527571.1169118330194.JavaMail.jira@brutus>
Date: Thu, 18 Jan 2007 03:05:30 -0800 (PST)
From: "Sian January (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-2973) [classlib] [luni] Concerns about
 synchronization in java.net.InetAddress
In-Reply-To: <5824478.1168511007499.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HARMONY-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465722 ] 

Sian January commented on HARMONY-2973:
---------------------------------------

I'm not sure about 1.  Surely if the notifying threads have finished before entering the main one then either reached will be true or addrCount will be 0 so we won't wait at all?  Also should the '&&' be an '||' on 897?

> [classlib] [luni] Concerns about synchronization in java.net.InetAddress
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-2973
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2973
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Sian January
>         Attachments: H-2973.patch
>
>
> FindBugs raised two concerns about synchronization in InetAddress.isReachableByMultiThread(...) - an unconditional wait on line 888, and also the fact that the same wait is not in a loop.  Looking more closely at this method I am concerned about the synchronization because it looks like it would be possible for no notify calls to occur after that wait, which would mean the wait would continue indefinitely.  It would be great if someone could take a look at this as I'm not entirely sure myself what the correct solution is.  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira