Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <11201546.1170060229506.JavaMail.jira@brutus>
Date: Mon, 29 Jan 2007 00:43:49 -0800 (PST)
From: "Alexey Petrenko (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Resolved: (HARMONY-2280) [classlib][swing] DefaultListModel
 method removeRange(int fromIndex, int toIndex) doesn't throw IAE for
 invalid parameters, when toIndex < fromIndex
In-Reply-To: <13589234.1164274682179.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HARMONY-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Petrenko resolved HARMONY-2280.
--------------------------------------

    Resolution: Fixed

I've applied Igor's test and modified patch from Vasily.
Please verify.

Vasily,
please use i18n for newly introduced error messages.

> [classlib][swing] DefaultListModel method removeRange(int fromIndex, int toIndex) doesn't throw IAE for invalid parameters, when toIndex < fromIndex
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2280
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2280
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Igor V. Stolyarov
>         Assigned To: Alexey Petrenko
>         Attachments: DefaultListModelTest.patch, Harmony-2280-Test.patch, Harmony-2280.patch
>
>
> DefaultListModel method removeRange(int fromIndex, int toIndex) doesn't throw IAE for invalid parameters, when toIndex < fromIndex.
> J2SE 1.5 specification says:
> Throws an IllegalArgumentException if fromIndex > toIndex. 
> Parameters: fromIndex - the index of the lower end of the range, toIndex - the
> index of the upper end of the range.
> Test for reproduce:
> Test.java---------------------------------------------------
> import javax.swing.*;
> public class Test{
>     public static void main(String[] args) {
>         DefaultListModel d = new DefaultListModel();
>         try {
>             d.removeRange(0, -1);
>             System.out.println("FAILED");
>         } catch (IllegalArgumentException iae) {
>             System.out.println("PASSED");
>         }
>     }
> }
> ------------------------------------------------------------
> Output
> Bea JRockit:
> java version "1.5.0"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0-b64)
> BEA WebLogic JRockit(R) (build dra-38972-20041208-2001-win-ia32, R25.0.0-75, GC:
>  System optimized over throughput (initial strategy singleparpar))
> PASSED
> ------------------------------------------------------------
> Harmony:
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundatio
> n or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r478058, (Nov 22 2006), Windows/ia32/msvc 1310, release build
> http://incubator.apache.org/harmony
> FAILED

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.