harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Blewitt (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2957) [classlib][pack200] Update pack200 project layout and ensure 1.4 compatibility
Date Wed, 31 Jan 2007 09:13:05 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468947

Alex Blewitt commented on HARMONY-2957:

This bug is the right place to discuss it, though.

> However, I didn't add your jar
> file because I'm not sure that placing a jar file in the module's root
> is a good idea. IMHO it would be better to create some sort of README
> in the module's root where the correct sequence of actions is
> described. Something about how this file can be created or what else
> can / should be done to simplify the eclipse user's life.

I did create the README -- you didn't apply it. It describes how the Jar can be created from
the java5 directory. However, without it, the Eclipse project doesn't build. The version is
merely a stub that enables the Eclipse project to be put together -- it's as much metadata
as the .project and .classpath or .settings directories are.

The alternative, and one which would also be better, is to have a pack200-java5 project, where
the source for the java5 source directories are. However, that's going to require a separate
directory and/or fragment and/or bundle, and I don't see much support for that idea.

So, if the Jar isn't going to be commited, we'll need to take it out of the modules/pack200/.classpath:

        <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER
-        <classpathentry exported="true" kind="lib" path="pack200-java5.jar"/>
        <classpathentry kind="output" path="bin/main"/>

and the (amended) readme can take care of generating and checking that in. Do you want me
to attach a patch to this issue for that, or do you want to do the change?

> [classlib][pack200] Update pack200 project layout and ensure 1.4 compatibility
> ------------------------------------------------------------------------------
>                 Key: HARMONY-2957
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2957
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>         Attachments: get-rid-of-test-exclusions.patch, pack200-java5.jar, pack200-project.patch
> This patch adds support for the Eclipse project to be based on 1.4 compatibility, rather
than 1.5 compatibility. I've split the Java source into two; src/main/java and src/main/java5
-- the latter needs to be compiled with a 1.5 system, the former with a 1.4 system. I've amended
the build.xml appropriately to have multiple targets in the appropriate sections, and tested
it out (though I've had to hack the build to get it to work on Mac OS X).
> I'm pretty sure there's a cleaner way of adding source folders than I've done, but I'm
open to suggestions. The src/main/java needs to be compiled on a 1.4 system, and the src/main/java5
needs to be compiled on a 1.5 (or with 1.5 support, anyway). To make life easier for an Eclipse
developer working on the project in 1.4 mode, the java5 has been exported to pack200-java5.jar
and included in with the patch (though, for some reason, the diff tool doesn't like binary
files so I'm having to attach it manually). 
> I've fixed the SegmentTest; I'm not sure if inheriting this again is a case of deleting
the make/excludes* files; but I've not done that in this patch. I can supply another patch
if this is the case.
> I've also written a new test to ensure that the compiled class files are generated with
1.4 compatibility, which should hopefully prevent this form being inadvertently reverted in
the future.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message