harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Ellison (JIRA)" <j...@apache.org>
Subject [jira] Assigned: (HARMONY-3008) [classlib][instrument]Releases byte array too early in the native code of redefine classes.
Date Mon, 29 Jan 2007 16:29:49 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tim Ellison reassigned HARMONY-3008:
------------------------------------

    Assignee: Tim Ellison

> [classlib][instrument]Releases byte array too early in the native code of redefine classes.
> -------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3008
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3008
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Leo Li
>         Assigned To: Tim Ellison
>         Attachments: patch-3008.diff
>
>
> In instrument.c, Java_org_apache_harmony_instrument_internal_InstrumentationImpl_redefineClasses_1native,
we have:
> Line 237:
>      class_bytes = (*env)->GetByteArrayElements(env, jclass_bytes, &copy);
> 		  if(NULL == class_bytes){
> 			hymem_free_memory(class_definitions);
> 			return;
> 		  }
> 		  class_byte_count = (*env)->GetArrayLength(env, jclass_bytes);
>           if(copy == JNI_TRUE){
> 		    (*env)->ReleaseByteArrayElements(env,jclass_bytes, class_bytes, JNI_ABORT);
>           }
> 	  
> 		  //construct a jvmtiClassDefinition element		  
> 		  class_definitions[index].klass=klass;
> 		  class_definitions[index].class_bytes=class_bytes;
> 		  class_definitions[index].class_byte_count=class_byte_count;
> 	  }
> 	  //perform redefinition
> 	  err=(*jvmti)->RedefineClasses(jvmti, length, class_definitions);
> the class_bytes are freed before RedefineClasses of JVM_TI uses them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message