harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oliver Deakin (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HARMONY-2886) [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE
Date Thu, 11 Jan 2007 16:26:27 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Oliver Deakin resolved HARMONY-2886.
------------------------------------

    Resolution: Fixed

Thanks Vasily and Ilya.
Patch applied at revision r495282. Please check that the patch applied as expected.

Note: I did not apply the exclude list patch due to the previous comment.

> [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null)
returns valid result while RI throws NPE
> --------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2886
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2886
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Ilya Okomin
>         Assigned To: Oliver Deakin
>            Priority: Minor
>         Attachments: Harmony-2886-Make.patch, Harmony-2886-Test.patch, Harmony-2886.patch
>
>
> javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null)
> returns valid result while RI throws NPE.
> Test for reproducing:
> ------------- Test.java -------------
> import javax.swing.plaf.basic.BasicComboBoxUI;
> import junit.framework.TestCase;
> import junit.textui.TestRunner;
> public class test extends TestCase {
>     public static void main(String args[]) {
>         TestRunner.run(test.class);
>     }
>     public void testRun() {
>         BasicComboBoxUI lb = new BasicComboBoxUI();
>         BasicComboBoxUI.ComboBoxLayoutManager b = lb.new ComboBoxLayoutManager();
>         try {
>             b.minimumLayoutSize(null);
>             fail("NPE expected");
>         } catch (NullPointerException e) {
>             // expected
>         }
>     }
> }
> ------------------------------
> Output on RI
> ==========
> .
> Time: 0.281
> OK (1 test)
> Output on Harmony:
> ================
> .F
> Time: 4.979
> There was 1 failure:
> 1) testRun(test)junit.framework.AssertionFailedError: NPE expected
> 	at test.testRun(test.java:17)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> 	at test.main(test.java:9)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message