harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nadya Morozova (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2966) [website] Add caveats about binary files in svn diffs
Date Mon, 15 Jan 2007 16:55:27 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464854
] 

Nadya Morozova commented on HARMONY-2966:
-----------------------------------------

Thanks for this suggestion! 
I'll look into this patch. A first glance shows you're adding really useful stuff. However,
the simple merge has not worked (some differences in the text) - I'll try resolve the conflict
soon.
cosmetic suggestions: 
- use <code></code> tags instead of single quotes ' ' to mark commands, filenames,
etc. we've followed this conventions in a number of pages on the website, so being consistent
could help.
- use <source>, not <pre> for preformatted text in xml files. Both actually work,
but <source> was especially introduced for xml-based website, so again for consistency
reasons, we might as well stick to one version as much as possible. 
what do you say?

Cheers, Nadya

> [website] Add caveats about binary files in svn diffs
> -----------------------------------------------------
>
>                 Key: HARMONY-2966
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2966
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Website/Documentation
>            Reporter: Alex Blewitt
>         Assigned To: Nadya Morozova
>            Priority: Minor
>         Attachments: get-involved.xml.patch
>
>
> Adding caveat for binary files, along with a 'grep' command that can be used to determine
such in an existing patch

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message