harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vasily Zakharov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1725) [swing] javax.swing.RepaintManager.addInvalidComponent(JComponent jcomp) throws unspecified NPE
Date Sun, 07 Jan 2007 23:51:27 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462892
] 

Vasily Zakharov commented on HARMONY-1725:
------------------------------------------

Attached fix and test patches.


> [swing] javax.swing.RepaintManager.addInvalidComponent(JComponent  jcomp) throws unspecified
 NPE
> -------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1725
>                 URL: https://issues.apache.org/jira/browse/HARMONY-1725
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Vera Aristova
>            Priority: Minor
>         Attachments: Harmony-1725-Make.patch, Harmony-1725-Test.patch, Harmony-1725.patch,
patch1725, patch1725
>
>
> javax.swing.RepaintManager.addInvalidComponent(JComponent  jcomp) throws unspecified
 NPE when jcomp is null,   while RI does not throw it.
> test for reproducing:
> import junit.framework.TestCase;
> import javax.swing.JComponent;
> import javax.swing.RepaintManager;
> import javax.swing.JToolTip;
> public class test extends TestCase 
> {
> 	public void testAddInvalidComponent() 
> 	{
> 		RepaintManager localRepaintManager = new RepaintManager();
> 		JToolTip localJToolTip = new JToolTip();
> 		localRepaintManager.addInvalidComponent(localJToolTip);
> 		JComponent c = null;
> 		try
> 		{
> 			localRepaintManager.addInvalidComponent(c);
> 		}
> 		catch(NullPointerException e){
> 			fail("unexpected NPE is thrown");}
> 	}
> }
> OUTPUT:
> HARMONY
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundatio
> n or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r450941, (Sep 28 2006), Windows/ia32/msvc 1310, release build
> http://incubator.apache.org/harmony
> .F
> Time: 0.344
> There was 1 failure:
> 1) testAddInvalidComponent(test)junit.framework.AssertionFailedError: unexpected
>  NPE is thrown
>         at test.testAddInvalidComponent(test.java:19)
>         at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0
> ------------------------------------------------------------------------
> SUN
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> .
> Time: 0.781
> OK (1 test)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message