harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sian January (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2973) [classlib] [luni] Concerns about synchronization in java.net.InetAddress
Date Wed, 17 Jan 2007 16:39:30 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465430
] 

Sian January commented on HARMONY-2973:
---------------------------------------

Thanks for looking at this Mikhail.  Your patch looks great and fixes the FindBugs complaints.
 The only thing I would suggest is that you might want to make the wait on line 899 longer
than 100 milliseconds, because if the notifying threads are taking a long time then that loop
will be running a lot.  If the notifying threads are quick then the wait will be interrupted
anyway so I don't think it would be a problem waiting for longer.  Maybe 1000ms or more? 
What do you think?

> [classlib] [luni] Concerns about synchronization in java.net.InetAddress
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-2973
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2973
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Sian January
>         Attachments: H-2973.patch
>
>
> FindBugs raised two concerns about synchronization in InetAddress.isReachableByMultiThread(...)
- an unconditional wait on line 888, and also the fact that the same wait is not in a loop.
 Looking more closely at this method I am concerned about the synchronization because it looks
like it would be possible for no notify calls to occur after that wait, which would mean the
wait would continue indefinitely.  It would be great if someone could take a look at this
as I'm not entirely sure myself what the correct solution is.  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message