harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Zakharov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-3017) [classlib][sql] Implementation for SerialClob constructors,getCharacterStream(), and length() methods.
Date Mon, 22 Jan 2007 16:40:29 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466497
] 

Alexei Zakharov commented on HARMONY-3017:
------------------------------------------

Hi Andrew, thanks for the patch, looks good. Just one question, In SerialClob#SerialClob(Clob)
you have:

        } catch (IOException e) {
            throw new SerialException("SerialClob: " + e.getMessage());
        }

but I think that it's more useful if we have something like this:

        } catch (IOException e) {
            SerialException se = new SerialException("SerialClob: " + e.getMessage());

            se.initCause(e);
            throw se;
        }

IMHO this is a standard practice since Java 1.4. Does it make sence?

> [classlib][sql] Implementation for SerialClob constructors,getCharacterStream(), and
length() methods.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3017
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3017
>             Project: Harmony
>          Issue Type: New Feature
>          Components: Classlib
>            Reporter: Andrew Zhang
>         Assigned To: Alexei Zakharov
>         Attachments: patch.diff
>
>
> Hi,
> I'll upload the implementation for SerialClob constructors,getCharacterStream(), and
length() methods soon.
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message