harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2052) [drlvm] Improve/re-implement a parser of generic signatures
Date Thu, 18 Jan 2007 10:51:30 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465718

Alexey Varlamov commented on HARMONY-2052:

Very nice - so it appears the parser has no kernel or VMI dependency - just signature and
reflected object as inputs are enough? That's excellent, the 1st step already brought desired
parser API simplification! 
I suppose we need not commit this patch, please keep going.

> [drlvm] Improve/re-implement a parser of generic signatures
> -----------------------------------------------------------
>                 Key: HARMONY-2052
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2052
>             Project: Harmony
>          Issue Type: Task
>          Components: Classlib, DRLVM
>            Reporter: Alexey Varlamov
>         Assigned To: Paulex Yang
>            Priority: Minor
>         Attachments: HARMONY-2052-1.diff
> Improve/re-implement a parser of generic signatures in DRLVM kernel classes [1], and
move this functionality to classlib (luni ?), so other VMs could reuse it for 1.5 support.
The current impl is somewhat messy and half-baked, one need to invent more shaped and modular
API to the parser. One more possible issue is parser's dependency on antlr, which may be considered
overkill for this duty. I think antlr has its pros, like more illustrative code with clear
correlation to formal grammar [2]; unfortunately this is not the case with the impl in question.
OTOH minimizing number of dependencies for VM is always good. 
> [1] working_vm\vm\vmcore\src\kernel_classes\javasrc\org\apache\harmony\lang\reflect\**

> [2]  http://java.sun.com/docs/books/vmspec/2nd-edition/ClassFileFormat-Java5.pdf Para

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message