harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey A. Ivanov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2782) [classlib][swing] j.s.text.DefaultCaret.install doesn't throw NPE whereas RI does
Date Wed, 24 Jan 2007 09:51:49 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-2782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466962
] 

Alexey A. Ivanov commented on HARMONY-2782:
-------------------------------------------

Mark,

This bug is duplicate of HARMONY-1750. And the patches were already applied, that's why the
regression test passes.

However I'd like this fix to be applied because it makes code more clear. And NPE is naturally
thrown but not with
if (c == null) {
    throw new NullPointerException();
}

which I consider ugly.


The test patches are different in the approach:
* Mine adds a separate test case for this situation,
* Whereas in HARMONY-1750 a new assertion is added into testInstall() method.

> [classlib][swing] j.s.text.DefaultCaret.install doesn't throw NPE whereas RI does
> ---------------------------------------------------------------------------------
>
>                 Key: HARMONY-2782
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2782
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexey A. Ivanov
>            Priority: Minor
>         Attachments: H2782-DefaultCaretTest.patch, H2782-javax.swing.text.patch, H2782-o.a.h.awt.text.TextCaret.patch
>
>
> javax.swing.text.DefaultCaret.install(null) works silently on Harmony whereas RI throws
NullPointerException.
> ======= Code to Reproduce =======
> import javax.swing.text.DefaultCaret;
> public class Test {
>     public static void main(String[] args) {
>         new DefaultCaret().install(null);
>         System.err.println("silent");
>     }
> }
> ======== end of code ======
> ------- Harmony -------
> silent
> ------- end -------
> ------- RI -------
> java.lang.NullPointerException
> 	at javax.swing.text.DefaultCaret.install(DefaultCaret.java:659)
> 	at Test.main(Test.java:5)
> ------- end -------

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message