harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Salikh Zakirov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2059) [drlvm] ThreadMXBean native methods implementation
Date Mon, 22 Jan 2007 16:42:29 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-2059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466498
] 

Salikh Zakirov commented on HARMONY-2059:
-----------------------------------------

I have reviewed the patch and noticed following issues:

Java_org_apache_harmony_lang_management_ThreadMXBeanImpl_findMonitorDeadlockedThreadsImpl():
leaks threads and dead_threads

Java_org_apache_harmony_lang_management_ThreadMXBeanImpl_getAllThreadIdsImpl(): leaks threads

Java_org_apache_harmony_lang_management_ThreadMXBeanImpl_getDaemonThreadCountImpl(): leaks
threads

Several global variables introduced, which should have been made HyThreadLibrary fields instead.
vm/thread/src/thread_ti_timing.c: thread_cpu_time_enabled, 
vm/thread/src/thread_ti_others: thread_contention_monitoring_enabled, total_started_thread_count,
peak_thread_count

FIXMEs in the patch look like they should be fixed before committing:
update_peak_count(): 
  // FIXME: exclude iterator and use global alive_java_thread_count
I think it should be fixed before committing.

 // FIXME: there are two different ids for one thread now - one returned by 
 // java.lang.Thread.getId() and the other returned by hythread_get_id(native thread).
 // They have to be the same.
 // This method returns the same id as java.lang.Thread.getId()

 // FIXME: there are two different ids for one thread now - one returned by 
 // java.lang.Thread.getId() and the other returned by hythread_get_id(native thread).
 // They have to be the same and iterator have to be excluded here.
 // The parameter of the method is the same id as java.lang.Thread.getId()


> [drlvm] ThreadMXBean native methods implementation
> --------------------------------------------------
>
>                 Key: HARMONY-2059
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2059
>             Project: Harmony
>          Issue Type: New Feature
>          Components: DRLVM
>            Reporter: Sergey Petrovsky
>         Attachments: jlm_drlvm_tm_support.patch
>
>
> Replaces ThreadMXBean stubs from HARMONY-1821 with real implementation

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message