harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ndbe...@apache.org
Subject svn commit: r502073 - in /harmony/enhanced/classlib/trunk/modules/luni/src: main/java/org/apache/harmony/luni/util/Util.java test/java/org/apache/harmony/luni/util/UtilTest.java
Date Thu, 01 Feb 2007 02:01:03 GMT
Author: ndbeyer
Date: Wed Jan 31 18:01:02 2007
New Revision: 502073

URL: http://svn.apache.org/viewvc?view=rev&rev=502073
Log:
Tweak Util toASCII methods; add a unit test for Util

Added:
    harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/util/UtilTest.java
  (with props)
Modified:
    harmony/enhanced/classlib/trunk/modules/luni/src/main/java/org/apache/harmony/luni/util/Util.java

Modified: harmony/enhanced/classlib/trunk/modules/luni/src/main/java/org/apache/harmony/luni/util/Util.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/org/apache/harmony/luni/util/Util.java?view=diff&rev=502073&r1=502072&r2=502073
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/luni/src/main/java/org/apache/harmony/luni/util/Util.java
(original)
+++ harmony/enhanced/classlib/trunk/modules/luni/src/main/java/org/apache/harmony/luni/util/Util.java
Wed Jan 31 18:01:02 2007
@@ -269,8 +269,9 @@
 	}
 	
 	public static String toASCIILowerCase(String s) {
-		StringBuffer buffer = new StringBuffer();
-		for (int i = 0; i < s.length(); i++) {
+        int len = s.length();
+		StringBuilder buffer = new StringBuilder(len);
+		for (int i = 0; i < len; i++) {
 			char c = s.charAt(i);
 			if ('A' <= c && c <= 'Z') {
 				buffer.append((char) (c + ('a' - 'A')));
@@ -282,8 +283,9 @@
 	}
 	
 	public static String toASCIIUpperCase(String s) {
-		StringBuffer buffer = new StringBuffer();
-		for (int i = 0; i < s.length(); i++) {
+        int len = s.length();
+        StringBuilder buffer = new StringBuilder(len);
+        for (int i = 0; i < len; i++) {
 			char c = s.charAt(i);
 	        if ('a' <= c && c <= 'z') {
 	        	buffer.append((char) (c - ('a' - 'A')));

Added: harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/util/UtilTest.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/util/UtilTest.java?view=auto&rev=502073
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/util/UtilTest.java
(added)
+++ harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/util/UtilTest.java
Wed Jan 31 18:01:02 2007
@@ -0,0 +1,56 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one or more
+ *  contributor license agreements.  See the NOTICE file distributed with
+ *  this work for additional information regarding copyright ownership.
+ *  The ASF licenses this file to You under the Apache License, Version 2.0
+ *  (the "License"); you may not use this file except in compliance with
+ *  the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+
+package org.apache.harmony.luni.util;
+
+import junit.framework.TestCase;
+
+public class UtilTest extends TestCase {
+
+    public void testToASCIILowerCase() {
+        assertEquals("abcdefghijklmnopqrstuvwxyz", Util //$NON-NLS-1$
+                .toASCIILowerCase("ABCDEFGHIJKLMNOPQRSTUVWXYZ")); //$NON-NLS-1$
+        
+        for (int i = 0; i < 255; i++) {
+            if (i >= 'a' && i <= 'z') {
+                continue;
+            }
+            if (i >= 'A' && i <= 'Z') {
+                continue;
+            }
+            String cString = "" + (char)i; //$NON-NLS-1$
+            assertEquals(cString, Util.toASCIILowerCase(cString));
+        }
+    }
+
+    public void testToASCIIUpperCase() {
+        assertEquals("ABCDEFGHIJKLMNOPQRSTUVWXYZ", Util //$NON-NLS-1$
+                .toASCIIUpperCase("abcdefghijklmnopqrstuvwxyz")); //$NON-NLS-1$
+        
+        for (int i = 0; i < 255; i++) {
+            if (i >= 'a' && i <= 'z') {
+                continue;
+            }
+            if (i >= 'A' && i <= 'Z') {
+                continue;
+            }
+            String cString = "" + (char)i; //$NON-NLS-1$
+            assertEquals(cString, Util.toASCIIUpperCase(cString));
+        }
+    }
+
+}

Propchange: harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/util/UtilTest.java
------------------------------------------------------------------------------
    svn:eol-style = native



Mime
View raw message