harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Markov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2470) [classlib][luni][test] Harmony unit test org.apache.harmony.luni.tests.java.lang.PackageTest.test#isCompatibleWithLjava_lang_String is incorect
Date Wed, 31 Jan 2007 19:03:05 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469158
] 

Mikhail Markov commented on HARMONY-2470:
-----------------------------------------

Thanks, Alexey for the integration!

Nevertheless i'm not agree with your resolution about excuding the whole PackageTest - it
contains 8 more testcases and i don't think that the whole test should be excluded due to
failure of 1 test case. Instead I suggest doing the following:
1) Leave the fix in DRLVM
2) Remove the "RI throws NPE..." section from test_isCompatibleWithLjava_lang_String() testcase
so IBM VM also pass the whole test, and remove the test from exclude list so it could be used
for testin and in CC runs.
3) Add Package2Test with this extended part ("RI throws NPE..." section) and add it to excluded
lists for IBM.
4) Modify the summary for this JIRA to have [classlib][drlvm] prefix
5) Close it as fixed for drlvm
6) Open similar JIRA with [classlib][ibm vme] prefix and describe the situation there (with
linking to this JIRA).

What do you think?

> [classlib][luni][test] Harmony unit test org.apache.harmony.luni.tests.java.lang.PackageTest.test#isCompatibleWithLjava_lang_String
is incorect
> -----------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2470
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2470
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Artem Aliev
>         Assigned To: Alexey Varlamov
>         Attachments: H-2470_drlvm.patch, H-2470_test.patch
>
>
> According to J2SE API 5.0 specifications of java.lang.Package class:
> "Specification version numbers use a syntax that consists of positive decimal 
> integers separated by periods ".", for example "2.0" or "1.2.3.4.5.6.7". This 
> allows an extensible number to be used to represent major, minor, micro, etc. 
> versions. The version specification is described by the following formal 
> grammar: 
> SpecificationVersion: 
>     Digits RefinedVersionopt 
> RefinedVersion: 
>     . Digits 
>     . Digits RefinedVersion 
> Digits: 
>     Digit 
>     Digits 
> Digit: 
>     any character for which Character.isDigit(char) returns true, e.g. 0, 1, 
>     2, ... 
> "
> But the following Harmony unit test 
> org.apache.harmony.luni.tests.java.lang.PackageTest.test invokes
> Package.isCompatibleWith(String) with incorrect argument "2.1.9." to compare
> package's specification version with a desired version.
> See test case "test_isCompatibleWithLjava_lang_String".
> As the result this test case fails on RI and reports:
> test_isCompatibleWithLjava_lang_String(org.apache.harmony.luni.tests.java.lang.PackageTest)junit.framework.AssertionFailedError:
> Exception during isCompatibleWith test : For input string: ""
>         at
> org.apache.harmony.luni.tests.java.lang.PackageTest.test_isCompatibleWithLjava_lang_String(PackageTest.java:331)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>         at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message