harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2969) [drlvm] patch to build jitrino in debug mode with gcc 4.1.0
Date Thu, 11 Jan 2007 12:08:27 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463874
] 

Alexey Varlamov commented on HARMONY-2969:
------------------------------------------

Seems this assert never worked anyway, because value was casted to int32 and compared to UINT32_MAX,
always evaluated to "true". More correct fix is:
-    assert((so != MemOpndSubOpndKind_Displacement)  || (abs((int32)opnd->getImmValue())
<= 0xffffffff));
+    assert((so != MemOpndSubOpndKind_Displacement)  || ((uint64)abs((int64)opnd->getImmValue())
<= 0xffffffff));


> [drlvm] patch to build jitrino in debug mode with gcc 4.1.0
> -----------------------------------------------------------
>
>                 Key: HARMONY-2969
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2969
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: RHEL4 update 4, x86, core 2 duo
>            Reporter: Naveen Neelakantam
>         Assigned To: Alexey Varlamov
>            Priority: Trivial
>         Attachments: Ia32Inst.cpp.patch
>
>
> Patch fixes a trivial compilation error.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message