harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey A. Ivanov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1792) [classlib][swing]javax.swing.tex.htmlFormView.getMaximumSpan(int axis) does not throw IllegalArgumentException for invalid axis
Date Mon, 29 Jan 2007 15:17:49 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468300
] 

Alexey A. Ivanov commented on HARMONY-1792:
-------------------------------------------

Alexey,

I completely agree with about the fix.


Could you please resolve HTML tests problem: they reside in "modules\swing\src\test\api\java.injected"
whereas the rest of Swing tests are in "modules\swing\src\test\api\java". The issue should
be resolved as soon as possible before many duplicate HTML testing related classes were created
in "modules\swing\src\test\api\java" which -- to some extent -- copy tests from "modules\swing\src\test\api\java.injected"
and to enable running of HTML tests as Harmony has HTML parser now.

See the discussion: http://thread.gmane.org/gmane.comp.java.harmony.devel/16591

> [classlib][swing]javax.swing.tex.htmlFormView.getMaximumSpan(int axis) does not throw
IllegalArgumentException for invalid axis
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1792
>                 URL: https://issues.apache.org/jira/browse/HARMONY-1792
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Svetlana Samoilenko
>         Assigned To: Alexey Petrenko
>            Priority: Minor
>         Attachments: FormViewTest.patch, H1792-FormView.patch
>
>
> Description:
> According to the specification getMaximumSpan(int axis) must throw IllegalArgumentException
- for an invalid axis.
> axis - may be either View.X_AXIS or View.Y_AXIS (0 or 1).
> Harmony does not throw specified exception for invalid axis.
> Test for reproducing:
> import junit.framework.TestCase;
> import javax.swing.text.*;
> import javax.swing.text.html.*;
> public class test extends TestCase  {          
>     public void testgetMaximumSpan_I(){
>         HTMLDocument doc = new HTMLDocument();
>         Element par=doc.getDefaultRootElement(); 
>         FormView obj=new FormView(par); 
>         try {
>             obj.getMaximumSpan(11);
>             fail("IllegalArgumentException should be thrown");
>         } catch (IllegalArgumentException e) {
>             //expected
>         } 
>     }     
> }
> HARMONY output:
> ==============
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r453981, (Oct  9 2006), Windows/ia32/msvc 1310, release build
> http://incubator.apache.org/harmony
> There was 1 failure:
> 1) testElementIterator_DocumentNull(test)junit.framework.AssertionFailedError: NullPointerException
should be thrown
>         at test.testElementIterator_DocumentNull(test.java:8)
>         at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0
> SUN output:
> =========
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> .
> Time: 0.01
> OK (1 test)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message