harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vasily Zakharov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2590) [classlib][swing][plaf] javax.swing.plaf.BorderUIResource.BevelBorderUIResource(int) throws unspecified InvalidParameterException
Date Wed, 17 Jan 2007 23:32:30 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465604
] 

Vasily Zakharov commented on HARMONY-2590:
------------------------------------------

Otherwise, the Harmony behavior looks correct - it's pretty clear that bevel can't be of any
other type than RAISED and LOWERED.
RI just ignores the incorrect bevel type values (getBevelType() returns the passed value),
while Harmony checks it and throws exception.

There are two ways to resolve this issue:

1. Decide Harmony is more right and consider this a non-bug difference. Disadvantage: some
not-so-accurate applications may break.
In this case, we just need to replace java.security.InvalidParameterException with IllegalArgumentException.

2. Decide to follow RI pattern and ignore the incorrect bevel type values.
In this case we just need to remove the check.

I'm not sure which way we should follow.


> [classlib][swing][plaf] javax.swing.plaf.BorderUIResource.BevelBorderUIResource(int)
throws unspecified InvalidParameterException
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2590
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2590
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Anton Luht
>            Priority: Minor
>
> javax.swing.plaf.BorderUIResource.BevelBorderUIResource(int) throws unspecified InvalidParameterException
while RI does not
> Code to reproduce:
> import javax.swing.plaf.*;
> public class Test {
>         public static void main(String args[]) {
>            new BorderUIResource.BevelBorderUIResource(199);
>         }
> }
> Output in RI: none
> Output in Harmony:
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundatio
> n or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r485537, (Dec 11 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> Uncaught exception in main:
> java.security.InvalidParameterException: Incorrect type of the bevel border
>         at javax.swing.border.BevelBorder.setBevelType(BevelBorder.java:62)
>         at javax.swing.border.BevelBorder.<init>(BevelBorder.java:43)
>         at javax.swing.plaf.BorderUIResource$BevelBorderUIResource.<init>(Border
> UIResource.java)
>         at Test.main(Test.java:5)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message