harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey A. Ivanov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1767) [classlib][swing]javax.swing.text.ComponentView(Element) throws unexpected NullPointerException on user's implementation
Date Fri, 19 Jan 2007 08:02:30 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465975
] 

Alexey A. Ivanov commented on HARMONY-1767:
-------------------------------------------

Vasily,

It looks that you haven't run the test case for StyleConstants on RI because it fails: NPE
is thrown because the AttributeSet passed is null. The fact the test fails confirms my guess
that your fix should have been included into ComponentView rather than into StyleConstants.

Thank you for the improvement of the test case in ComponentViewTest.

> [classlib][swing]javax.swing.text.ComponentView(Element) throws unexpected NullPointerException
on user's implementation
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1767
>                 URL: https://issues.apache.org/jira/browse/HARMONY-1767
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Svetlana Samoilenko
>         Assigned To: Mark Hindess
>            Priority: Trivial
>         Attachments: ComponentViewTest.patch, Harmony-1767-Test.patch, Harmony-1767-Test2.patch,
Harmony-1767.patch
>
>
> Harmony throws unexpected NPE for ComponentView(Element) on user's Element implementation.
> RI works correctly.
> Test for reproducing:
> import junit.framework.TestCase;
> import javax.swing.text.*;
> import javax.swing.text.html.*;
> public class test extends TestCase  {          
>     
>     public void testSetParent_View(){    	
>         HTMLDocument doc = new HTMLDocument();
>         Element e=doc.getDefaultRootElement();
>         ComponentView obj = new ComponentView(new testElement());
>         obj.setParent(new ListView(e));        
>      }  
>     private class testElement implements Element {
>         public boolean isLeaf() {
>             return false;
>         }
>         public Element getElement(int p0) {
>             return null;
>         }
>         public int getElementCount() {
>             return 0;
>         }
>         public int getElementIndex(int p0) {
>             return 0;
>         }
>         public int getEndOffset() {
>             return 0;
>         }       
>         public int getStartOffset() {
>             return 0;
>         }       
>         public AttributeSet getAttributes() {
>             return null;
>         }
>         public String getName() {
>             return "AA";
>         }
>         public Element getParentElement() {
>             return null;
>         }
>         public Document getDocument() {
>             return null;
>         }
>     }
> }
> HARMONY output:
> =============
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundation or
its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r450941, (Sep 28 2006), Windows/ia32/msvc 1310, release build
> http://incubator.apache.org/harmony
> .E
> Time: 0.578
> There was 1 error:
> 1) testSetParent_View(test)java.lang.NullPointerException
>         at javax.swing.text.StyleConstants.getComponent(StyleConstants.java:202)
>         at javax.swing.text.ComponentView.createComponent(ComponentView.java:182)
>         at javax.swing.text.ComponentView.setParent(ComponentView.java:163)
>         at test.testSetParent_View(test.java:9)
>         at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> FAILURES!!!
> Tests run: 1,  Failures: 0,  Errors: 1
> SUN output:
> ==========
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> .
> Time: 0.01
> OK (1 test

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message