harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-3015) [classlib] [security] Fixes for some minor bugs in the security module found by FindBugs
Date Thu, 18 Jan 2007 07:10:29 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-3015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465666
] 

Alexey Varlamov commented on HARMONY-3015:
------------------------------------------

Actual fixes look good, except the following:
--- src/main/java/common/java/security/BasicPermission.java	(revision 494820)
+++ src/main/java/common/java/security/BasicPermission.java	(working copy)
@@ -140,7 +140,7 @@
      * It is assumed that names cannot be null or empty.
      */
     static boolean nameImplies(String thisName, String thatName) {
-        if (thisName == thatName) {
+        if (thisName.equals(thatName)) {
             return true;
         }
         int end = thisName.length();

The "==" operator is used deliberately, to check fastpath.

> [classlib] [security] Fixes for some minor bugs in the security module found by FindBugs
> ----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3015
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3015
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Sian January
>            Priority: Minor
>         Attachments: exclusionFilter.xml.patch, security.patch
>
>
> I am attaching a patch containing fixes for minor issues in the security module, and
also a second patch for the exclusionFilter.xml file found in standard/tools/FindBugs to exclude
false positives in the same module.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message