harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Zakharov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-840) [classlib][beans] enabling of tests from StatementTest class (3)
Date Thu, 25 Jan 2007 12:27:49 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467347

Alexei Zakharov commented on HARMONY-840:

We may close it IMHO.

> [classlib][beans] enabling of tests from StatementTest class (3)
> ----------------------------------------------------------------
>                 Key: HARMONY-840
>                 URL: https://issues.apache.org/jira/browse/HARMONY-840
>             Project: Harmony
>          Issue Type: Improvement
>         Environment: winXP
>            Reporter: Alexei Zakharov
>         Assigned To: Mikhail Loenko
>         Attachments: StatementTest3.patch
> Attached patch enables two more tests from org.apache.harmony.beans.tests.java.beans.StatementTest:
> testExecute_ArrayGet
> testExecute_ArrayInvalidSet
> What have been done:
> 1. I have reworked the exception throwing model of Statement.findArrayMethod(). Now our
implementation throws the same set of exceptions as RI does. 
> 2. I have also removed superfluous parameters from "get" and "set" invocations from tests
since tests in their old form were invalid. However, old variants of tests pass on RI. IMHO
it is RI bug. I have started new mail thread in the list about this topic. Anyway, even if
we decide to be 100% compatible with RI here we will probably need do define an extra test.
We don't need to test this doubtful logic in these tests IMHO.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message