Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 49430 invoked from network); 20 Dec 2006 15:13:46 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 20 Dec 2006 15:13:46 -0000 Received: (qmail 68919 invoked by uid 500); 20 Dec 2006 15:13:53 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 68904 invoked by uid 500); 20 Dec 2006 15:13:53 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 68895 invoked by uid 99); 20 Dec 2006 15:13:53 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Dec 2006 07:13:53 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Dec 2006 07:13:45 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 8EFF57142AB for ; Wed, 20 Dec 2006 07:13:25 -0800 (PST) Message-ID: <9726391.1166627605583.JavaMail.jira@brutus> Date: Wed, 20 Dec 2006 07:13:25 -0800 (PST) From: "Alexey Petrenko (JIRA)" To: commits@harmony.apache.org Subject: [jira] Commented: (HARMONY-2811) [classlib] [luni] Fixes for some minor issues in luni found by Melody (FindBugs) In-Reply-To: <8375466.1166606421058.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ http://issues.apache.org/jira/browse/HARMONY-2811?page=comments#action_12459961 ] Alexey Petrenko commented on HARMONY-2811: ------------------------------------------ Great and huge job, Sian! But some of the changes need more details... Index: luni/src/main/java/org/apache/harmony/luni/platform/AdapterManager.java =================================================================== @@ -35,7 +35,7 @@ private final HashMap> factories = new HashMap>(); public Object getAdapter(IAdaptable adaptable, Class adapterType) { - List factoryList = factories.get(adaptable); + List factoryList = factories.get(adapterType); if (factoryList != null) { for (Iterator factoryItr = factoryList.iterator(); factoryItr .hasNext();) { =================================================================== Are you sure that this is good replacement? Index: luni/src/main/java/org/apache/harmony/luni/platform/DebugMemorySpy.java =================================================================== --- luni/src/main/java/org/apache/harmony/luni/platform/DebugMemorySpy.java (revision 486101) +++ luni/src/main/java/org/apache/harmony/luni/platform/DebugMemorySpy.java (working copy) @@ -25,7 +25,7 @@ */ final class DebugMemorySpy extends AbstractMemorySpy { - private final boolean stackDump = true; + private static final boolean stackDump = true; =================================================================== FindBugs reports that stackDump is not used. It probably should be removed but not marked as static. > [classlib] [luni] Fixes for some minor issues in luni found by Melody (FindBugs) > -------------------------------------------------------------------------------- > > Key: HARMONY-2811 > URL: http://issues.apache.org/jira/browse/HARMONY-2811 > Project: Harmony > Issue Type: Bug > Components: Classlib > Reporter: Sian January > Assigned To: Alexey Petrenko > Priority: Minor > Attachments: exclusionFilter_patch.txt, findbugs_patch.txt > > > As summary -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira