Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <32503346.1166450244348.JavaMail.jira@brutus>
Date: Mon, 18 Dec 2006 05:57:24 -0800 (PST)
From: "Alexey A. Ivanov (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Updated: (HARMONY-2777) [classlib][swing]
 j.s.text.AbstractDocument.BranchElement.get{Start, End}Offset throw
 ArrayIndexOutOfBoundsException rather than NPE
In-Reply-To: <11033655.1166449281130.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

     [ http://issues.apache.org/jira/browse/HARMONY-2777?page=all ]

Alexey A. Ivanov updated HARMONY-2777:
--------------------------------------

    Attachment: H2777-AbstractDocument.patch

The fix: added explicit throwing of NPE to getStartOffset() and getEndOffset() methods.

> [classlib][swing] j.s.text.AbstractDocument.BranchElement.get{Start, End}Offset throw ArrayIndexOutOfBoundsException rather than NPE
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2777
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2777
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexey A. Ivanov
>            Priority: Minor
>         Attachments: H2777-AbstractDocument.patch, H2777-AbstractDocument_BranchElementTest.patch
>
>
> The spec states that getEndOffset throws NPE if the element has no children [1].
> The spec doesn't say anything about exceptions for getStartOffset() [2]. However, it also throws NPE in this case. The behavior of these methods should be similar in respect to exceptions.
> [1] http://java.sun.com/j2se/1.5.0/docs/api/javax/swing/text/AbstractDocument.BranchElement.html#getEndOffset()
> [2] http://java.sun.com/j2se/1.5.0/docs/api/javax/swing/text/AbstractDocument.BranchElement.html#getStartOffset()
> ======= Code to Reproduce =======
> import javax.swing.text.PlainDocument;
> import javax.swing.text.AbstractDocument.BranchElement;
> public class Test {
>     public static void main(String[] args) {
>         PlainDocument doc = new PlainDocument();
>         BranchElement branch = doc.new BranchElement(null, null);
>         try {
>             System.err.println(branch.getStartOffset());
>         } catch (Exception e) {
>             System.err.println("getStartOffset:");
>             e.printStackTrace();
>         }
>         try {
>             System.err.println(branch.getEndOffset());
>         } catch (Exception e) {
>             System.err.println("getEndOffset:");
>             e.printStackTrace();
>         }
>     }
> }
> ======= end of code =======
> ------- Harmony Output -------
> getStartOffset:
> java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 0
> 	at javax.swing.text.AbstractDocument$BranchElement.getStartOffset(AbstractDocument.java:419)
> 	at Test.main(Test.java:9)
> getEndOffset:
> java.lang.ArrayIndexOutOfBoundsException: Array index out of range: -1
> 	at javax.swing.text.AbstractDocument$BranchElement.getEndOffset(AbstractDocument.java:48)
> 	at Test.main(Test.java:15)
> ------- end of Harmony -------
> ------- RI Output -------
> getStartOffset:
> java.lang.NullPointerException
> 	at javax.swing.text.AbstractDocument$BranchElement.getStartOffset(AbstractDocument.java:2331)
> 	at Test.main(Test.java:9)
> getEndOffset:
> java.lang.NullPointerException
> 	at javax.swing.text.AbstractDocument$BranchElement.getEndOffset(AbstractDocument.java:2343)
> 	at Test.main(Test.java:15)
> ------- end of RI -------

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira