Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <28442533.1165921942271.JavaMail.jira@brutus>
Date: Tue, 12 Dec 2006 03:12:22 -0800 (PST)
From: "Mikhail Markov (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Updated: (HARMONY-1691)
 [claaslib][rmi]java.rmi.server.LogStream.write(byte[], int,int) does not
 throw IndexOutOfBoundsException in case of boundary violation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

     [ http://issues.apache.org/jira/browse/HARMONY-1691?page=all ]

Mikhail Markov updated HARMONY-1691:
------------------------------------

    Attachment: LogStream.patch

Here is the fix for the bug.

> [claaslib][rmi]java.rmi.server.LogStream.write(byte[], int,int) does not throw IndexOutOfBoundsException in case of boundary violation
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1691
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1691
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Svetlana Samoilenko
>         Attachments: LogStream.patch, LogStreamTestPatch.txt
>
>
> Description: 
> java.rmi.server.LogStream.write(byte[]buf, int off,int len) does not throw IndexOutOfBoundsException if off is negative, or len is negative, 
> or off+len is greater than the length of the array buf.
> There is no mention of any exceptions in the specification.
> Test for reproducing: 
> import junit.framework.TestCase;
> import java.rmi.server.*;
> public class test extends TestCase {      
>     public void testWrite_BA_I_I()  {
>        try {            
>            LogStream obj = LogStream.log("proba");
>            obj.write(new byte[]{1,1},-2,-6);
>            fail("IndexOutOfBoundsException should be thrown");
>        } catch (IndexOutOfBoundsException e) {
>            //expected
>        }
>       try {            
>            LogStream obj = LogStream.log("NN");
>            obj.write(new byte[]{1,1},6,1);
>            fail("IndexOutOfBoundsException should be thrown");            
>        } catch (IndexOutOfBoundsException e) {
>            //expected
>        }
>        try {            
>            LogStream obj = LogStream.log("NN");
>            obj.write(new byte[]{1,1},0,6);
>            fail("IndexOutOfBoundsException should be thrown");            
>        } catch (IndexOutOfBoundsException e) {
>            //expected
>        }                        
>     } 
> }
> Output on Sun 1.5: 
> ================== 
> java version "1.5.0_06" 
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05) 
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode) 
> .
> Time: 0 
> OK (1 test) 
> Output on Harmony: 
> ================== 
>  Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundation or its licensors, as applicable. 
> java version "1.5.0" pre-alpha : not complete or compatible 
> svn = r452710, (Oct 4 2006), Windows/ia32/msvc 1310, release build 
> http://incubator.apache.org/harmony 
> .F
> Time: 0.047
> There was 1 failure:
> 1) testWrite_BA_I_I(test)junit.framework.AssertionFailedError: IndexOutOfBoundsException should be thrown
>         at test.testWrite_BA_I_I(test.java:11)
>         at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira