Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <16643870.1166716821308.JavaMail.jira@brutus>
Date: Thu, 21 Dec 2006 08:00:21 -0800 (PST)
From: "Sian January (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Created: (HARMONY-2840) [classlib] [luni] Some inner classes
 could be removed or changed to static inner classes (FindBugs)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

[classlib] [luni] Some inner classes could be removed or changed to static inner classes (FindBugs)
---------------------------------------------------------------------------------------------------

                 Key: HARMONY-2840
                 URL: http://issues.apache.org/jira/browse/HARMONY-2840
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
            Reporter: Sian January
            Priority: Minor


A static inner class takes up less space in memory, so if an inner class doesn't use the reference to the parent object it makes sense to turn it into a static inner class.  I have also found a couple of instances where an inner class has been used as a lock object, but there didn't seem to be any reason why the synchronization wasn't done on the parent object, so this bug also addresses that.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira