Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <13556107.1165906223066.JavaMail.jira@brutus>
Date: Mon, 11 Dec 2006 22:50:23 -0800 (PST)
From: "Alexey Varlamov (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-2556) [classlib] [luni] Fixes for some
 minor issues in the java.lang and java.io packages found by Melody
In-Reply-To: <3761292.1165590861072.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/HARMONY-2556?page=comments#action_12457599 ] 
            
Alexey Varlamov commented on HARMONY-2556:
------------------------------------------

The only side effect I can think of is NPE thrown on that redundant call to String.length() - i.e. this is tricky way to validate input arg. I did not check this though.
Regarding SecurityManager, the code is still incorrect - see HARMONY 2301. It's a pity I did not commit it early, need to adjust the patch now.

> [classlib] [luni] Fixes for some minor issues in the java.lang and java.io packages found by Melody
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2556
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2556
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Sian January
>         Assigned To: Tim Ellison
>            Priority: Minor
>         Attachments: exclusionFilter_patch.txt, java.io_patch.txt, java.lang_patch.txt
>
>
> As summary.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira