From commits-return-20929-apmail-harmony-commits-archive=harmony.apache.org@harmony.apache.org Tue Dec 05 01:18:44 2006 Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 87800 invoked from network); 5 Dec 2006 01:18:43 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 5 Dec 2006 01:18:43 -0000 Received: (qmail 97308 invoked by uid 500); 5 Dec 2006 01:18:52 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 97214 invoked by uid 500); 5 Dec 2006 01:18:52 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 97205 invoked by uid 99); 5 Dec 2006 01:18:52 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Dec 2006 17:18:52 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Dec 2006 17:18:43 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id EA9757142BF for ; Mon, 4 Dec 2006 17:18:22 -0800 (PST) Message-ID: <28059912.1165281502958.JavaMail.jira@brutus> Date: Mon, 4 Dec 2006 17:18:22 -0800 (PST) From: "Alex Blewitt (JIRA)" To: commits@harmony.apache.org Subject: [jira] Commented: (HARMONY-2246) [classlib][pack200] Ongoing implementation In-Reply-To: <10110232.1164068942041.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ http://issues.apache.org/jira/browse/HARMONY-2246?page=comments#action_12455487 ] Alex Blewitt commented on HARMONY-2246: --------------------------------------- Thanks, I've gone through this and it looks good. The testHelloWorld can be ignored for now; I've put in a bit more stringent error checking which means that file won't parse any more (before, it was ignoring anything else on the end). Probably the best thing to do is to comment out the test method itself: public class SegmentTest extends TestCase { /** * @param args * @throws Exception */ // public void testHelloWorld() throws Exception { // assertNotNull(Segment.parse(Segment.class // .getResourceAsStream("/org/apache/harmony/archive/tests/internal/pack200/HelloWorld.pack"))); // } When I implement the next bit (which is parsing the code bands) this error won't be thrown any more. But basically, it's because I've not got as far as decoding the bytecode yet :-) Do you want me to attach another patch with this, or would you be able to comment out this method for now? > [classlib][pack200] Ongoing implementation > ------------------------------------------ > > Key: HARMONY-2246 > URL: http://issues.apache.org/jira/browse/HARMONY-2246 > Project: Harmony > Issue Type: New Feature > Components: Classlib > Reporter: Alex Blewitt > Assigned To: Alexey Petrenko > Priority: Trivial > Attachments: harmony200.patch, pack200.tgz, pack200.tgz > > > The pack200 code is now capable of unpacking multiple classes and interfaces, along with primitive (byte/short/char/int/long/float/double) and String constant values. It can only handle abstract/native methods at this stage and no internal classes, but it's a fair bit further on than the last successfully applied patch. > This patch was generated on the command line against the previous SVN repository from the root of the project (i.e. relative paths). It also includes the newly added files which weren't all correctly added last time. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira