harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Petrenko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2811) [classlib] [luni] Fixes for some minor issues in luni found by Melody (FindBugs)
Date Wed, 20 Dec 2006 15:13:25 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-2811?page=comments#action_12459961 ] 
            
Alexey Petrenko commented on HARMONY-2811:
------------------------------------------

Great and huge job, Sian!

But some of the changes need more details...
Index: luni/src/main/java/org/apache/harmony/luni/platform/AdapterManager.java
===================================================================
@@ -35,7 +35,7 @@
 	private final HashMap<Class, List<IAdapterFactory>> factories = new HashMap<Class,
List<IAdapterFactory>>();
 
 	public Object getAdapter(IAdaptable adaptable, Class adapterType) {
-		List factoryList = factories.get(adaptable);
+		List factoryList = factories.get(adapterType);
 		if (factoryList != null) {
 			for (Iterator factoryItr = factoryList.iterator(); factoryItr
 					.hasNext();) {
===================================================================
Are you sure that this is good replacement?

Index: luni/src/main/java/org/apache/harmony/luni/platform/DebugMemorySpy.java
===================================================================
--- luni/src/main/java/org/apache/harmony/luni/platform/DebugMemorySpy.java	(revision 486101)
+++ luni/src/main/java/org/apache/harmony/luni/platform/DebugMemorySpy.java	(working copy)
@@ -25,7 +25,7 @@
  */
 final class DebugMemorySpy extends AbstractMemorySpy {
 
-	private final boolean stackDump = true;
+	private static final boolean stackDump = true;
===================================================================
FindBugs reports that stackDump is not used. It probably should be removed but not marked
as static.



> [classlib] [luni] Fixes for some minor issues in luni found by Melody (FindBugs)
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-2811
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2811
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Sian January
>         Assigned To: Alexey Petrenko
>            Priority: Minor
>         Attachments: exclusionFilter_patch.txt, findbugs_patch.txt
>
>
> As summary

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message