harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2540) [drlvm][testing] Regression Testing Infrastructure implementation.
Date Wed, 27 Dec 2006 11:13:22 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-2540?page=comments#action_12460976 ] 
            
Alexey Varlamov commented on HARMONY-2540:
------------------------------------------

Alexander, your latest patch basically undoes my modifications for uncoupling reg.test targets
with super-duper meta-component-designed drlvm build system, and removes regression/H0000
test. I did both mods to your original patch deliberately, targeting greater simplicity and
painless transition to better build infrastructure in future. The H0000 test is a nice grindstone
for the regression framework so I prefer to keep it fot now.
The only essence improvement I see is the following bit:

Index: build/make/targets/reg.test.run.xml
===================================================================
--- build/make/targets/reg.test.run.xml	(revision 490268)
+++ build/make/targets/reg.test.run.xml	(working copy)
@@ -146,9 +146,10 @@
             <junit jvm="${jvm.under.test}"
                    fork="yes"
                    haltonfailure="false"
-                   haltonerror="false"
+                   haltonerror="${reg.test.halt.on.error}"
                    printsummary="withOutAndErr"
                    dir="${basedir}"
+                   errorproperty="reg.test.errors"
                    failureproperty="reg.test.errors"
                    timeout="${reg.test.timeout}">
                 <jvmarg line="@{vmarg}"/>
@@ -160,9 +161,19 @@
                 <formatter type="brief"/>
                 <formatter type="xml"/>
             </junit>
+            <if>
+                <isset property="reg.test.custom.launched"/>
+                <then>
+                    <fail message="${reg.test.failed.mark}">
+                        <condition>
+                            <istrue value="${reg.test.errors}"/>
+                        </condition>
+                    </fail>
+                </then>
+            </if>
         </sequential>
     </macrodef>

BTW, the last one is a good sample to improve ant-scripting style. Compare to the following
alternative:
@@ -160,9 +161,10 @@
                 <formatter type="brief"/>
                 <formatter type="xml"/>
             </junit>
+           <fail message="${reg.test.failed.mark}" if="${reg.test.errors}"/>
         </sequential>
     </macrodef>

> [drlvm][testing] Regression Testing Infrastructure implementation.
> ------------------------------------------------------------------
>
>                 Key: HARMONY-2540
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2540
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Alexander Kleymenov
>         Assigned To: Alexey Varlamov
>         Attachments: patch-reg-test-fwk.txt, patch-regression-testing.txt
>
>
> At present the using of DRLVM regression testing is complicated by the following reasons:
>     - It does not support automated test integration: integration of new regression test
requires changes in build system.
>     - It does not contain the document describing the directions for developers of new
regression tests.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message