harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vera Volynets (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2505) Class file parser improvements
Date Fri, 08 Dec 2006 14:34:32 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-2505?page=comments#action_12456847 ] 
            
Vera Volynets commented on HARMONY-2505:
----------------------------------------

Alexey,
Thank you for your notes.
I've tested my changes on windows ia32 build test and build vm on linux em_64t.
I agree with 1) and 2) and will follow your advices for the next patches.
4) I've changed 
return index > 0 && index < m_size;
to 
return index != 0 && index < m_size;
5) I've dropped common_attrs because although those attributes are common
for Classes, fields and methods attributes for Classes were parsed separetaly 
from attributes for fields and methods. So code duplication is not avoided.
Also common parsing attributes mechanism was too sophisticated and complecated code reading.

As I understand JVM specification there are attributes which
must be recognized by each file reader within context of their use in JVMS.
For example, if Code attribute is met in field function _parse_attributes returned ATTR_Code
and  java/lang/InternalError was thrown instead
of simple skipping. 

> Class file parser improvements
> ------------------------------
>
>                 Key: HARMONY-2505
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2505
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Vera Volynets
>         Attachments: class_file_parser_improvements_20061207.patch
>
>
> I've found out that classloader misses a number of
> checks from specification about Class File Format.
> The patch with improvements is attached.
> Some checks described in TODO list in the patch are omitted.
> I'll continue working on them.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message