harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Fedotov (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HARMONY-2906) [drlvm] applying code inspection comments to compile.cpp
Date Wed, 27 Dec 2006 20:19:22 GMT
     [ http://issues.apache.org/jira/browse/HARMONY-2906?page=all ]

Alexei Fedotov updated HARMONY-2906:

    Attachment: code_inspection_compile_me_3.patch

[based on Gregory feedback] Slightly rearranged spaces in exception messages to make it possible
to be Sun compliant in exception messages. Now the following code added right before
    JIT_Result res = compile_do_compilation(method);
at the compile_me() function will produce a Sun-like exception message (no extra space).

+ if (method->is_abstract()) { 
+     compile_raise_exception("java/lang/AbstractMethodError", "", method); 
+     tmn_suspend_disable(); 
+     return NULL; 
+ } 

Gregory, if you think being compliant with Sun in exception messages is important, then please
apply code_inspection_compile_me_3.patch, otherwise code_inspection_compile_me_2.patch is
good enough.

> [drlvm] applying code inspection comments to compile.cpp
> --------------------------------------------------------
>                 Key: HARMONY-2906
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2906
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: DRLVM
>            Reporter: Alexei Fedotov
>         Attachments: code_inspection_compile_me.patch, code_inspection_compile_me.txt,
code_inspection_compile_me_2.patch, code_inspection_compile_me_3.patch
> The patch extracts a beautification part of the fix of HARMONY-2528 [drlvm] VM crashes
instead of throwing AbstractMethodError. The patch is important because a simple solution
of HARMONY-2528 is possible after the patch is applied.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message