harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Blewitt (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2246) [classlib][pack200] Ongoing implementation
Date Tue, 05 Dec 2006 01:18:22 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-2246?page=comments#action_12455487 ] 
            
Alex Blewitt commented on HARMONY-2246:
---------------------------------------

Thanks, I've gone through this and it looks good. The testHelloWorld can be ignored for now;
I've put in a bit more stringent error checking which means that file won't parse any more
(before, it was ignoring anything else on the end). Probably the best thing to do is to comment
out the test method itself:

public class SegmentTest extends TestCase {
	/**
	 * @param args
	 * @throws Exception
	 */
//	public void testHelloWorld() throws Exception {
//		assertNotNull(Segment.parse(Segment.class
//				.getResourceAsStream("/org/apache/harmony/archive/tests/internal/pack200/HelloWorld.pack")));
//	}

When I implement the next bit (which is parsing the code bands) this error won't be thrown
any more. But basically, it's because I've not got as far as decoding the bytecode yet :-)

Do you want me to attach another patch with this, or would you be able to comment out this
method for now?

> [classlib][pack200] Ongoing implementation
> ------------------------------------------
>
>                 Key: HARMONY-2246
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2246
>             Project: Harmony
>          Issue Type: New Feature
>          Components: Classlib
>            Reporter: Alex Blewitt
>         Assigned To: Alexey Petrenko
>            Priority: Trivial
>         Attachments: harmony200.patch, pack200.tgz, pack200.tgz
>
>
> The pack200 code is now capable of unpacking multiple classes and interfaces, along with
primitive (byte/short/char/int/long/float/double) and String constant values. It can only
handle abstract/native methods at this stage and no internal classes, but it's a fair bit
further on than the last successfully applied patch.
> This patch was generated on the command line against the previous SVN repository from
the root of the project (i.e. relative paths). It also includes the newly added files which
weren't all correctly added last time.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message