harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Ellison (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HARMONY-2840) [classlib] [luni] Some inner classes could be removed or changed to static inner classes (FindBugs)
Date Fri, 22 Dec 2006 13:51:22 GMT
     [ http://issues.apache.org/jira/browse/HARMONY-2840?page=all ]

Tim Ellison resolved HARMONY-2840.

    Resolution: Fixed

Thanks Sian,

Slightly modified version of patch applied to LUNI module at repo revision r489652.

Please check that the patch was applied as you expected.

> [classlib] [luni] Some inner classes could be removed or changed to static inner classes
> ---------------------------------------------------------------------------------------------------
>                 Key: HARMONY-2840
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2840
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Sian January
>         Assigned To: Tim Ellison
>            Priority: Minor
>         Attachments: luni_patch.txt
> A static inner class takes up less space in memory, so if an inner class doesn't use
the reference to the parent object it makes sense to turn it into a static inner class.  I
have also found a couple of instances where an inner class has been used as a lock object,
but there didn't seem to be any reason why the synchronization wasn't done on the parent object,
so this bug also addresses that.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message