harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sian January (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2840) [classlib] [luni] Some inner classes could be removed or changed to static inner classes (FindBugs)
Date Fri, 22 Dec 2006 14:05:23 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-2840?page=comments#action_12460482 ] 
            
Sian January commented on HARMONY-2840:
---------------------------------------

Thanks Tim - patch applied as expected.

> [classlib] [luni] Some inner classes could be removed or changed to static inner classes
(FindBugs)
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2840
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2840
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Sian January
>         Assigned To: Tim Ellison
>            Priority: Minor
>         Attachments: luni_patch.txt
>
>
> A static inner class takes up less space in memory, so if an inner class doesn't use
the reference to the parent object it makes sense to turn it into a static inner class.  I
have also found a couple of instances where an inner class has been used as a lock object,
but there didn't seem to be any reason why the synchronization wasn't done on the parent object,
so this bug also addresses that.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message