harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Egor Pasko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2424) [drlvm] Inlining of array allocation helper.
Date Wed, 06 Dec 2006 12:39:22 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-2424?page=comments#action_12455985 ] 
Egor Pasko commented on HARMONY-2424:


I tried your ver2 patch on SUSE9 ia32, smoke tests and kernel tests passed smoothly *in server
I reviewed the JIT part. The patch is great! A couple of remarks:

1. Why is helper inliner pipeline so short? only "ssa" pass.. 
   There could be at least "simplify"

2. it is probably time to refactor JavaByteCodeTranslator a little to avoid
   copy-pasted code like this for each helper:

+    if (!strcmp(mname,"newVectorUsingAllocHandle")) {
+        assert(numArgs == 3);
+        Opnd* res = irBuilder.genVMHelperCall(CompilationInterface::Helper_NewVector_UsingVtable,
resType, numArgs, srcOpnds);
+        pushOpnd(res);
+        return;
+    }

3. strncmp is a better replacement to strcmp

> [drlvm] Inlining of array allocation helper.
> --------------------------------------------
>                 Key: HARMONY-2424
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2424
>             Project: Harmony
>          Issue Type: New Feature
>          Components: DRLVM
>            Reporter: Mikhail Fursov
>         Attachments: allocArray.diff, allocArray_2.diff, allocArray_3.diff
> The implementation of inlining of arrays allocation helper.
> The patch contains:
> 1) The code of array allocation helper written in Java.
> 2) JIT modifications to inline the array allocation helper.
> 3) JIT modification to support InlinePragma method marker for helpers.
> 4) Minor fixes in Jitrino.OPT magics support found while testing.
> The array allocation helper inlining will be enabled by default in -Xem:server mode after
the patch is applied.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message