harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Kleymenov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2540) [drlvm][testing] Regression Testing Infrastructure implementation.
Date Thu, 28 Dec 2006 05:33:23 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-2540?page=comments#action_12461149 ] 
Alexander Kleymenov commented on HARMONY-2540:


> Alexander, your latest patch basically undoes my modifications for uncoupling
> reg.test targets with super-duper meta-component-designed drlvm build system,
> and removes regression/H0000 test. 

Thanks for asking. Let's go file by file:

reg.test.xml, build.xml: 
I made your changes to comply with overall DRLVM build system. 
Believe me, it is better than commenting <select> element :)
This fix SHOULD be applied.

First - it fixes indentation problem made by your patch 
(+1 extra space char at the beginning of the lines).

Second - "super-duper" is an error reporting system used by custom 
test launchers. The framework is incomplete without it. 
This fix SHOULD be applied.

> The H0000 test is a nice grindstone for the
> regression framework so I prefer to keep it fot now.  

At the beginning this test was provided as an example and it is not 
connected with any issue report. 
So it is NOT A REGRESSION TEST (by definition) and SHOULD be removed 
from regression test suite.

> + <if> 
> + <isset property="reg.test.custom.launched"/> 
> + <then> 
> + <fail message="${reg.test.failed.mark}"> 
> + <condition> 
> + <istrue value="${reg.test.errors}"/> 
> + </condition> 
> + </fail> 
> + </then> 
> + </if> 
>          </sequential> 
>      </macrodef> 
> BTW, the last one is a good sample to improve ant-scripting style. 
> Compare to the following alternative: 
> @@ -160,9 +161,10 @@ 
>                  <formatter type="brief"/> 
>                  <formatter type="xml"/> 
>              </junit> 
> + <fail message="${reg.test.failed.mark}" if="${reg.test.errors}"/> 

I believe you know Ant well, but your suggestion does different 
things from expected. I'm not happy with it (and reg testing framework

So I made a conclusion that patch should be applied as it is.


> [drlvm][testing] Regression Testing Infrastructure implementation.
> ------------------------------------------------------------------
>                 Key: HARMONY-2540
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2540
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Alexander Kleymenov
>         Assigned To: Alexey Varlamov
>         Attachments: patch-reg-test-fwk.txt, patch-regression-testing.txt
> At present the using of DRLVM regression testing is complicated by the following reasons:
>     - It does not support automated test integration: integration of new regression test
requires changes in build system.
>     - It does not contain the document describing the directions for developers of new
regression tests.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message