harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Kleymenov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2540) [drlvm][testing] Regression Testing Infrastructure implementation.
Date Thu, 28 Dec 2006 07:36:23 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-2540?page=comments#action_12461158 ] 
            
Alexander Kleymenov commented on HARMONY-2540:
----------------------------------------------

> 1) Strict compliance with DRLVM build system is not required; enough
> said why we want to replace it (just browse dev-list archive if
> interested) and this framework could be a training ground for
> alternative approach. 

I don't want my work to be your training ground. 
Work out definite rules for your "alternative approach" first!
Commenting of not working lines does not seem to be right.
Although you are committer and you are deciding what is right and what is wrong.
But in the future don't tell me I didn't warn you :)

> Regarding the <select>, could you please explain
> why we need to link with libstc++ here? Anyway, there should be
> conventional alternative to that hack with <select>.

You do not provide me with information about build conventions, 
why should I tell you about libstc++ ? :) (hint - try to compile cpp on *nix)

> 2) Please do not intermix functional changes with beautifications -
> let's skip wrong indentation for now.

I want my work to be of hight quality. But your extra space make its
look as a bugaboo. I can't understand your reasons to do this.
 
> 3) Error reporting is incomplete indeed (as it was in the original
> patch), dedicated patch is welcomed (probably in separate JIRA).

Please, don't mix JVM crash handling and test failure report. This is a
second one. What about former - let's leave it for a next discussion.
 
> 4) Extra test does no harm, right? Missing JIRA entry does not void this
> test, it still to be included somewhere - so let's keep it for a while

It's still in src/test/jni/nio . 
It was an example taken from there. And now I don't want it to be here. 
So, please, remove it from regression test suite.

Alexander

> [drlvm][testing] Regression Testing Infrastructure implementation.
> ------------------------------------------------------------------
>
>                 Key: HARMONY-2540
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2540
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Alexander Kleymenov
>         Assigned To: Alexey Varlamov
>         Attachments: patch-reg-test-fwk.txt, patch-regression-testing.txt
>
>
> At present the using of DRLVM regression testing is complicated by the following reasons:
>     - It does not support automated test integration: integration of new regression test
requires changes in build system.
>     - It does not contain the document describing the directions for developers of new
regression tests.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message