harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Volosyuk (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2424) [drlvm] Inlining of array allocation helper.
Date Tue, 05 Dec 2006 13:01:22 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-2424?page=comments#action_12455619 ] 
            
Ivan Volosyuk commented on HARMONY-2424:
----------------------------------------

The patch will certainly break IPF and EM64T:

 +    private static final int GC_OBJECT_ALIGNMENT = 4; //TODO: EM64 or IPF could have 8!

GC_OBJECT_ALIGNMENT should be at least sizeof(void*) and should be equal to those in C header
files.
Even on 32 bit architecture it can be 8 after fixes for double 'volatile' fields handling.

Why the alloc is never null? Fast allocation helper will fail in some cases.
+            Address arrayAddress = alloc(size, allocationHandle); //never null!
+            arrayAddress.store(arrayLen, Offset.fromInt(ARRAY_LEN_OFFSET));
+            return arrayAddress;

I'm not familiar with jitrino, could some one else review the changes in it?

> [drlvm] Inlining of array allocation helper.
> --------------------------------------------
>
>                 Key: HARMONY-2424
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2424
>             Project: Harmony
>          Issue Type: New Feature
>          Components: DRLVM
>            Reporter: Mikhail Fursov
>         Attachments: allocArray.diff, allocArray_2.diff
>
>
> The implementation of inlining of arrays allocation helper.
> The patch contains:
> 1) The code of array allocation helper written in Java.
> 2) JIT modifications to inline the array allocation helper.
> 3) JIT modification to support InlinePragma method marker for helpers.
> 4) Minor fixes in Jitrino.OPT magics support found while testing.
> The array allocation helper inlining will be enabled by default in -Xem:server mode after
the patch is applied.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message