harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Ozhdikhin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2012) [drlvm][em] value-profling implemenation
Date Fri, 15 Dec 2006 05:51:23 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-2012?page=comments#action_12458681 ] 
Pavel Ozhdikhin commented on HARMONY-2012:


Thank you for your review.  Please see my comments below:

> * vm/jitrino/src/dynopt/ValueProfiler.cpp contains \r\n line endings as well as 
>   \n, need to fix to mere \n 

You are right, the patch has been prepared on Windows. Unfortunately it has been committed
as is. Alexey, could you please run dos2unix on the ValueProfiler.cpp?

> * vcproj files changes are quite unreadable, too many lines changed to \r\n, can we do

>   something with it? 

These are pure windows files and actually I don't know how to patch them correctly - do you?
So I just relied on patch command here and checked that patched files work.

> * BTW, why do we have "TNV profile collector" named ValuePofileCollector, IMHO, 
 >  makes sense to rename it to TopNValueProfileCollector 

"TNV profile collector" is a kind of "Value Profile Collector" so generally the name is correct.
You are right, if we decide to have another profile collector, we will need to choose another
name. But I don't think we'll need another profile collector in the near future and ValueProfileCollector
is a nice descriptive name so I'd postpone this change to the moment when we need another
profile collector.

Thanks again,

> [drlvm][em] value-profling implemenation
> ----------------------------------------
>                 Key: HARMONY-2012
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2012
>             Project: Harmony
>          Issue Type: New Feature
>          Components: DRLVM
>         Environment: independent
>            Reporter: Yuri Kashnikoff
>         Assigned To: Alexey Varlamov
>         Attachments: new_value_profiler.zip, patch_20061128.zip, patch_20061206.zip,
patch_20061207.zip, test.java, valueprof_10_11_2006.zip, valueprofiler.zip, valueprofiler.zip,
> Value profiling implementation may give some benefits to optimisation (and increase the

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message