harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stepan Mishura (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2882) [java][security]PKIXParameters.setDate(null) has no effect on the original date value on RI but Harmony sets it to null.
Date Wed, 27 Dec 2006 05:46:23 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-2882?page=comments#action_12460947 ] 
Stepan Mishura commented on HARMONY-2882:

Hi Leo,

I think Harmony follows the spec. for PKIXParameters.setDate(Date date). It says:
"public void setDate(Date date)
Sets the time for which the validity of the certification path should be determined. If null,
the current time is used..."

My undestanding is: null is a valid parameter and the spec. clearly states that if it is passed
to the method the current time is used.
But according to the test in the bug description RI ignores null value (IOW, it doesn't allow
to reset it to current time). Please note it accepts any non-null value (IOW, initial 'time'
value is not final and it allows to change it) and this looks inconsistent for me.

I'd mark this bug as "Non-bug differences from RI"


> [java][security]PKIXParameters.setDate(null) has no effect on the original date value
on RI but Harmony sets it to null.
> ------------------------------------------------------------------------------------------------------------------------
>                 Key: HARMONY-2882
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2882
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Leo Li
>         Assigned To: Stepan Mishura
>         Attachments: patch-2882.diff
> Here is a testcase:
> public void testSetDate()
> {
>    Set taSet = TestUtils.getTrustAnchorSet();
>    PKIXParameters p = new PKIXParameters(taSet);
>    Date toBeSet = new Date(555L);
>    p.setDate(toBeSet);
>   p.setDate(null);
>   assertEquals(555L, p.getDate().getTime());
> }
> RI passes.
> Harmony fails.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message