harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrey Pavlenko (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HARMONY-2493) [classlib][awt] java.awt.KeyboardFocusManager.getDefaultFocusTraversalKeys() returns null instead of correct object
Date Fri, 22 Dec 2006 14:28:28 GMT
     [ http://issues.apache.org/jira/browse/HARMONY-2493?page=all ]

Andrey Pavlenko updated HARMONY-2493:
-------------------------------------

    Attachment: KeyboardFocusManager.patch
                BasicTextUI.patch

Alexey, the issue is in the javax.swing.plaf.basic.BasicTextUI class - there are attempts
to modify unmodifiable map, returned by the Component.getFocusTraversalKeys() method. I've
attached the patch fixing this issue.
Also I've attached new patch for the KeyboardFocusManager class. This patch does not contain
code style formatting, thus it's more readable.

> [classlib][awt] java.awt.KeyboardFocusManager.getDefaultFocusTraversalKeys() returns
null instead of correct object
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2493
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2493
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Pavel Dolgov
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>         Attachments: BasicTextUI.patch, DefaultKeyboardFocusManager.patch, KeyboardFocusManager.patch,
KeyboardFocusManager.patch, KeyboardFocusManagerRTest.patch, KeyboardFocusManagerTest.patch,
PerfTest.java
>
>
> Test case:
> --------------
> import java.awt.AWTEvent;
> import java.awt.Component;
> import java.awt.Container;
> import java.awt.event.KeyEvent;
> import java.util.Set;
> import junit.framework.TestCase;
> public class TheTest extends TestCase {
>     public static void main(String args[]) {
>         junit.textui.TestRunner.run(TheTest.class);
>     }
>     public void testcase1() {
>         KeyboardFocusManagerImpl obj = new KeyboardFocusManagerImpl();
>         Set keys = obj.getDefaultFocusTraversalKeys(1);
>         assertNotNull(keys);
>         assertTrue(keys.size() > 0);
>     }
>     class KeyboardFocusManagerImpl extends java.awt.KeyboardFocusManager {
>         public KeyboardFocusManagerImpl() {
>             super();
>         }
>         public boolean dispatchEvent(AWTEvent arg0) {
>             return false;
>         }
>         public boolean dispatchKeyEvent(KeyEvent arg0) {
>             return false;
>         }
>         public boolean postProcessKeyEvent(KeyEvent arg0) {
>             return false;
>         }
>         public void processKeyEvent(Component arg0, KeyEvent arg1) {
>         }
>         protected void enqueueKeyEvents(long arg0, Component arg1) {
>         }
>         protected void dequeueKeyEvents(long arg0, Component arg1) {
>         }
>         protected void discardKeyEvents(Component arg0) {
>         }
>         public void focusNextComponent(Component arg0) {
>         }
>         public void focusPreviousComponent(Component arg0) {
>         }
>         public void upFocusCycle(Component arg0) {
>         }
>         public void downFocusCycle(Container arg0) {
>         }
>     }
> }
> RI output:
> -------------
> .
> Time: 0,991
> OK (1 test)
> Harmony output:
> --------------
> .F
> Time: 0.361
> There was 1 failure:
> 1) testcase1(TheTest)junit.framework.AssertionFailedError
> 	at TheTest.testcase1(TheTest.java:17)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> 	at TheTest.main(TheTest.java:12)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message