harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stepan Mishura (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2733) [java][security]AlgorithmParameters.getParamterSpec should throw NullPointerException if the input AlgorithmSpec class is null.
Date Tue, 19 Dec 2006 05:55:23 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-2733?page=comments#action_12459544 ] 
            
Stepan Mishura commented on HARMONY-2733:
-----------------------------------------

Hi Leo,

This issues is similar to HARMONY-2680. In this case NullPointerException is thrown by Sun's
provider and is not thrown by BC provider.
I've added test case to security module. It passes on RI and demonstrates that null value
is passed to corresponding spi-provider's method (engineGetParameterSpec(Class<T> paramSpec)
).

See:
modules/security/src/test/api/java/org/apache/harmony/security/tests/java/security/AlgorithmParametersTest.java


        //
        // test: if paramSpec is null
        //
        paramSpi = new MyAlgorithmParameters() {

            protected AlgorithmParameterSpec engineGetParameterSpec(
                    Class paramSpec) {
                assertNull(paramSpec); // null is passed to spi-provider
                return null;
            }
        };

        params = new DummyAlgorithmParameters(paramSpi, p, "algorithm");
        params.init(new MyAlgorithmParameterSpec());
        assertNull(params.getParameterSpec(null));

Thanks,
Stepan.

> [java][security]AlgorithmParameters.getParamterSpec should throw NullPointerException
if the input AlgorithmSpec class is null.
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2733
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2733
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Leo Li
>         Assigned To: Stepan Mishura
>         Attachments: patch-2733.diff
>
>
> Here is a testcase:
> public void test_algorithmParameters_getParamterSpec() throws Exception {
> 		AlgorithmParameters algorithmParameters = AlgorithmParameters
> 				.getInstance("DSA");
> 		algorithmParameters.init(new DSAParameterSpec(BigInteger.ONE,
> 				BigInteger.ONE, BigInteger.ONE));
> 		try {
> 			algorithmParameters.getParameterSpec(null);
> 			fail("should throw NullPointerException");
> 		} catch (NullPointerException e) {
> 			// expected
> 		}
> 	}
> RI passes.
> Harmony fails.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message